[Fizz] Fix crash when capturing the callsite of a stalled use() of a Flight chunk that was rejected in the meantime#36544
Merged
eps1lon merged 2 commits intoMay 26, 2026
Conversation
…Flight chunk that was rejected in the meantime
|
Comparing: 926fa85...f8abac7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
approved these changes
May 26, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
May 26, 2026
…Flight chunk that was rejected in the meantime (#36544) `ensureSuspendableThenableStateDEV` patches `then` in fulfilled thenables to avoid triggering a custom thenable's `then` in an unexpected state. However, we weren't doing the same for rejected thenables. This affected `ReactPromise`, the type used for thenables passed from server to client. if a `ReactPromise` passed to `use` was pending during the render but became rejected between the abort and `pushSuspendedCallSiteOnComponentStack`, then `ReactPromise#then` would crash. (see the added test for a reprouction) This is because we were putting the ReactPromise into an invalid state: a `PendingChunk` expects to have a `value: null | Array<...>`, but we were deleting `value` altogether, and tgus hitting `TypeError: can't access property "push" of undefined` here: https://github.com/facebook/react/blob/75b0945b18f4a60c80c931fd8067d9c715957879/packages/react-client/src/ReactFlightClient.js#L309 Bypassing the suspended thenable's `then` avoids this crash. DiffTrain build for [37fa36c](37fa36c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensureSuspendableThenableStateDEVpatchesthenin fulfilled thenables to avoid triggering a custom thenable'sthenin an unexpected state. However, we weren't doing the same for rejected thenables.This affected
ReactPromise, the type used for thenables passed from server to client. if aReactPromisepassed tousewas pending during the render but became rejected between the abort andpushSuspendedCallSiteOnComponentStack, thenReactPromise#thenwould crash. (see the added test for a reprouction)This is because we were putting the ReactPromise into an invalid state: a
PendingChunkexpects to have avalue: null | Array<...>, but we were deletingvaluealtogether, and tgus hittingTypeError: can't access property "push" of undefinedhere:react/packages/react-client/src/ReactFlightClient.js
Line 309 in 75b0945
Bypassing the suspended thenable's
thenavoids this crash.